systemdMinimal: fix build#432548
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Aug 10, 2025
Merged
Conversation
Remove broken patches. The nspawn conditional can be omitted,
as it will not be installed on `systemdLibs` anyways.
Testing done:
```
nix why-depends --precise .#systemdMinimal.out .#getent.out
/nix/store/x2dhq7nb43xv2c3hh8y7g4bkdzndy7av-systemd-minimal-257.7
└───bin/systemd-nspawn: …valid, ignoring....../nix/store/h5f0zw8gp3fsrzldsi9x2j29gqz6dv4h-getent-glibc-2.40-66/bin/getent…
→ /nix/store/h5f0zw8gp3fsrzldsi9x2j29gqz6dv4h-getent-glibc-2.40-66
```
```
'git+file:///home/grimmauld/coding/nixpkgs#systemdLibs.out' does not depend on 'git+file:///home/grimmauld/coding/nixpkgs#getent.out'
```
`systemdMinimal`, `systemdLibs`, `pam` all builds.
`pkgsMusl.pam` evals successfully.
LordGrimmauld
force-pushed
the
systemdMinimal_fix
branch
from
19e2e0f to
219ca69
Compare
nix-owners
bot
requested review from
ElvishJerricco,
aanderse,
arianvp and
flokli
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
Contributor
Author
|
okay, my systemd build just finished successfully. So should be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #418255 / 0afdb39
Remove broken patches. The nspawn conditional can be omitted, as it will not be installed on
systemdLibsanyways.Testing done:
systemdMinimal,systemdLibs,pamall builds.pkgsMusl.pamevals successfully.Currently building
systemd.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.