nixos/test-instrumentation: use bash directly#432290
Merged
RaitoBezarius merged 1 commit intoNixOS:masterfrom Aug 10, 2025
Merged
nixos/test-instrumentation: use bash directly#432290RaitoBezarius merged 1 commit intoNixOS:masterfrom
RaitoBezarius merged 1 commit intoNixOS:masterfrom
Conversation
RaitoBezarius
approved these changes
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change avoids depending on
/bin/shin a test and thus makes it possible to use the test driver in a system that doesn't have/bin/sh. Now, the module pulls in bash directly instead of delegating figuring out which shell to use toenv.This enables me to write a test that ensures there is no bash in the closure besides the one from the test driver.
Ran about 20 systemd tests so I'm very confident that this works just as well as before.
Part #428908
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.