Skip to content

nixos/test-instrumentation: use bash directly#432290

Merged
RaitoBezarius merged 1 commit intoNixOS:masterfrom
nikstur:test-instrumentation-bash
Aug 10, 2025
Merged

nixos/test-instrumentation: use bash directly#432290
RaitoBezarius merged 1 commit intoNixOS:masterfrom
nikstur:test-instrumentation-bash

Conversation

@nikstur
Copy link
Contributor

@nikstur nikstur commented Aug 9, 2025

This change avoids depending on /bin/sh in a test and thus makes it possible to use the test driver in a system that doesn't have /bin/sh. Now, the module pulls in bash directly instead of delegating figuring out which shell to use to env.

This enables me to write a test that ensures there is no bash in the closure besides the one from the test driver.

Ran about 20 systemd tests so I'm very confident that this works just as well as before.

Part #428908

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nikstur nikstur requested a review from ElvishJerricco August 9, 2025 15:50
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 9, 2025
@RaitoBezarius RaitoBezarius merged commit c230381 into NixOS:master Aug 10, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants