shadow: use /bin/sh as default shell#432117
Merged
fabianhjr merged 1 commit intoNixOS:stagingfrom Aug 13, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
arianvp
approved these changes
Aug 10, 2025
nixpkgs-ci
bot
added
12.approvals: 1
Contributor
Author
|
Cherry picked this change onto master and ran these tests:
Also cross compiled from x86 to aarch64 via pam-zfs-key is broken on master. |
nixpkgs-ci
bot
added
the
6.topic: nixos
See the comment in the code for the reason why using /bin/sh instead of the runtimeShell store path. Drop the patch and substituteInPlace in postPatch as this is much easier to maintain than a patch. Ldap users should now set `loginShell` to `/run/current-system/sw/bin/bash` if they want to retain bash as the default shell. If this is not set, the default shell for logins will be /bin/sh which can be "turned" into a normal interactive bash by typing "bash".
RaitoBezarius
approved these changes
Aug 10, 2025
nixpkgs-ci
bot
added
12.approvals: 2
Member
|
Really neat, thanks for your work/contribution towards minimizing requirements. Seems well tested enough for staging, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the patch and substituteInPlace in postPatch as this is much easier to maintain than a patch.
See the comment in the code for the reason why using /bin/sh instead of the runtimeShell store path.
Shadow shouldn't depend on bash to essentially bring it's own default shell. This is inherently something to be picked up from the ambient environment. Since /bin/sh is the only place that we are basically guaranteed to have use that.
Part of #428908
Will only be bashless after the linux-pam changes from #429972 That's why I didn't add the usual outputChecks here.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.