nixos/filesystem: remove mount-pstore#432049
Merged
arianvp merged 1 commit intoNixOS:masterfrom Aug 8, 2025
Merged
Conversation
Ever since fb49d81 we set CONFIG_PSTORE=y in the config because we set CONIFG_ACPI_APEI=y in the kernel. This means we always have pstore built right into the kernel. systemd thus always mounts `/sys/fs/pstore` which makes our custom unit superfluous and redudant.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
arianvp
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ever since fb49d81 we set CONFIG_PSTORE=y in the config because we set CONIFG_ACPI_APEI=y in the kernel. This means we always have pstore built right into the kernel.
systemd thus always mounts
/sys/fs/pstorewhich makes our custom unit superfluous and redudant.Part of #428908
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.