nixos/network-interfaces: let networkd handle privacy extensions#431967
nixos/network-interfaces: let networkd handle privacy extensions#431967RaitoBezarius merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Should set a default for systemd.network.config.networkConfig.IPv6PrivacyExtensions rather than adding a separate .network, but otherwise seems like a good idea. Scripted networking delenda est.
nikstur
force-pushed
the
networkd-privacy-extensions
branch
from
fe44fdc to
c516356
Compare
Done |
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Can you update the defaultText of systemd.network.config.networkConfig as appropriate, and probably move the default into the relevant module? (You can use networkd without networking.useNetworkd, and this default would still apply there, so it probably doesn’t belong in this file.)
This removes bash from the mandatory system closure.
nikstur
force-pushed
the
networkd-privacy-extensions
branch
from
c516356 to
bb954cd
Compare
|
Moved it into the networkd module.
Right now, this is always enabled so this change doesn't change the default NixOS behaviour. The only difference is that if you enable networkd, you now use native networkd features to set these flags. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
4 participants
Let networkd handle the privacy extensions when using networkd. Otherwise still use the custom udev rules.
This removes bash from the mandatory system closure.
Part of #428908
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.