valkey: set upper limit for parallelism in test-suite#431768
Merged
Ma27 merged 1 commit intoNixOS:masterfrom Aug 10, 2025
Merged
valkey: set upper limit for parallelism in test-suite#431768Ma27 merged 1 commit intoNixOS:masterfrom
Ma27 merged 1 commit intoNixOS:masterfrom
Conversation
On machines with many build cores, the tests either fail repeatedly or
don't even manage to start because all ports are blocked. For instance,
on a heavy machine with >350 threads, valkey was busy trying to find
ports for its tests for several hours:
[...]
Port 23380 was already busy, trying another port...
Port 23381 was already busy, trying another port...
Port 23382 was already busy, trying another port...
Port 23383 was already busy, trying another port...
Port 23384 was already busy, trying another port...
Port 23385 was already busy, trying another port...
Port 23386 was already busy, trying another port...
Port 23387 was already busy, trying another port...
Port 23388 was already busy, trying another port...
Port 23389 was already busy, trying another port...
Port 23390 was already busy, trying another port...
It should be noted that the tests seem to repeatedly use the same,
smallish range given it always tried to allocate ports in the range of
233xx.
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin staging-25.05
git worktree add -d .worktree/backport-431768-to-staging-25.05 origin/staging-25.05
cd .worktree/backport-431768-to-staging-25.05
git switch --create backport-431768-to-staging-25.05
git cherry-pick -x 8e4b0ab719788bfcbc76f635bb50fa307aa8b7f4 |
Contributor
|
@Ma27 can you create s backport please? |
This was referenced Aug 28, 2025
mdaniels5757
added
8.has: port to stable
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On machines with many build cores, the tests either fail repeatedly or don't even manage to start because all ports are blocked. For instance, on a heavy machine with >350 threads, valkey was busy trying to find ports for its tests for several hours:
It should be noted that the tests seem to repeatedly use the same, smallish range given it always tried to allocate ports in the range of 233xx.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.