Skip to content

gperftools: 2.15 -> 2.17#431675

Merged
K900 merged 1 commit intoNixOS:stagingfrom
LordGrimmauld:gperftools_2_17
Aug 10, 2025
Merged

gperftools: 2.15 -> 2.17#431675
K900 merged 1 commit intoNixOS:stagingfrom
LordGrimmauld:gperftools_2_17

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Aug 7, 2025

Changelog:

The TLS patch needed updating:

Notable changes:

  • pprof was removed -> no more perl dependency
  • google/ headers were removed after "long deprecation" upstream

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Aug 7, 2025
@nix-owners nix-owners bot requested a review from vcunat August 7, 2025 07:55
@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Aug 7, 2025

I built up to freecad with this, this seems to work

@MisileLab MisileLab mentioned this pull request Aug 7, 2025
Closed
13 tasks
@nikstur
Copy link
Contributor

nikstur commented Aug 9, 2025

arrow-cpp from ceph seems to be broken when cherry-picking this commit on master.

@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Aug 9, 2025

I am confused, arrow-cpp should have nothing to do with gperftools:

nixpkgs ❯ nix why-depends .#arrow-cpp .#gperftools --derivation
'git+file:///home/grimmauld/coding/nixpkgs#arrow-cpp' does not depend on 'git+file:///home/grimmauld/coding/nixpkgs#gperftools'

on  gperftools_2_17 [$] in bash took 15s
nixpkgs ❯ nix why-depends .#gperftools .#arrow-cpp --derivation
'git+file:///home/grimmauld/coding/nixpkgs#gperftools' does not depend on 'git+file:///home/grimmauld/coding/nixpkgs#arrow-cpp'

on  gperftools_2_17 [$] in bash
nixpkgs ❯

@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Aug 9, 2025

this means it builds fine, both on this PR branch and when cherry-picking to master, its not in the reverse closure

@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Aug 9, 2025 •
edited
Loading

ceph has some workarounds for arrow it seems, so yes it is building a different arrow-cpp, but that too does not depend on gperftools, meaning that break is unrelated

@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Aug 9, 2025 •
edited
Loading

ceph's arrow-cpp is broken on master too fwiw

@K900 K900 merged commit 00d6dc9 into NixOS:staging Aug 10, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat Awaiting requested review from vcunat

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LordGrimmauld @nikstur @K900