stdenv.mkDerivation: support mainProgram as a top‐level attribute#430810
Draft
emilazy wants to merge 2 commits intoNixOS:stagingfrom
Draft
stdenv.mkDerivation: support mainProgram as a top‐level attribute#430810emilazy wants to merge 2 commits intoNixOS:stagingfrom
emilazy wants to merge 2 commits intoNixOS:stagingfrom
Conversation
nix-owners
bot
requested review from
Artturin,
Ericson2314,
RossComputerGuy,
alyssais,
hsjobeki,
infinisil,
philiptaron and
reckenrode
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Ack |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nixpkgs-ci
bot
added
the
2.status: merge conflict
philiptaron
approved these changes
Aug 28, 2025
| ] | ||
| ++ optional (hasOutput "man") "man"; | ||
| } | ||
| // optionalAttrs (attrs ? mainProgram) { |
Contributor
There was a problem hiding this comment.
We should pull the same trick as #430969 here too.
Contributor
nixpkgs-ci
bot
added
the
12.approvals: 1
Closed
1 task
13 tasks
nixpkgs-ci
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #412768 (comment) for context. Totally untested, needs docs, could be a bikeshed magnet, would need eventual follow‐up with a tree‐wide and staged warnings/errors, etc., but putting it out there. This would also currently break
versionCheckHook’s default for any non‐migrated package, so we’d have to decide whether we want to pull it in as a full attribute for compatibility for now, or else couple reducing use of thepnamedefault to liftingmainProgramout. Also if this eventually gets merged and I see people bikeshedding about moving it in unrelated PRs rather than automating it I’ll lose it.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.