Skip to content

jetbrains.jdk-no-jcef-17: enable --disable-warnings-as-errors.#430439

Merged
adamcstephens merged 1 commit intoNixOS:masterfrom
aoli-al:fix-build
Dec 22, 2025
Merged

jetbrains.jdk-no-jcef-17: enable --disable-warnings-as-errors.#430439
adamcstephens merged 1 commit intoNixOS:masterfrom
aoli-al:fix-build

Conversation

@aoli-al
Copy link
Member

@aoli-al aoli-al commented Aug 2, 2025

Things done

The jetbrains.jdk-no-jcef-17 build on aarch64 is broken right now due to the following error:

jetbrains-jdk> In member function 'void Assembler::set_current(Instruction_aarch64*)',
jetbrains-jdk>     inlined from 'void Assembler::sbfm(Register, Register, unsigned int, unsigned int)' at /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:866:3:
jetbrains-jdk> /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:700:54: error: storing the address of local variable 'do_not_use' in '*this.Assembler::current' [-Werror=dangling-pointer=]
jetbrains-jdk>   700 |   void set_current(Instruction_aarch64* i) { current = i; }
jetbrains-jdk>       |                                              ~~~~~~~~^~~
jetbrains-jdk> /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp: In function 'void Assembler::sbfm(Register, Register, unsigned int, unsigned int)':
jetbrains-jdk> /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:316:36: note: 'do_not_use' declared here
jetbrains-jdk>   316 | #define starti Instruction_aarch64 do_not_use(this); set_current(&do_not_use)
jetbrains-jdk>       |                                    ^~~~~~~~~~
jetbrains-jdk> /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:857:5: note: in expansion of macro 'starti'
jetbrains-jdk>   857 |     starti;                                                             \
jetbrains-jdk>       |     ^~~~~~
jetbrains-jdk> /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:866:3: note: in expansion of macro 'INSN'
jetbrains-jdk>   866 |   INSN(sbfm,  0b1001001101, 1);
jetbrains-jdk>       |   ^~~~
jetbrains-jdk> /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:856:67: note: 'this' declared here
jetbrains-jdk>   856 |   void NAME(Register Rd, Register Rn, unsigned immr, unsigned imms) {   \
jetbrains-jdk>       |                                                                   ^
jetbrains-jdk> /build/source/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:866:3: note: in expansion of macro 'INSN'
jetbrains-jdk>   866 |   INSN(sbfm,  0b1001001101, 1);
jetbrains-jdk>       |   ^~~~

This is probably caused by gcc version updates. This patch temporary fixes the build by disabling the warning as error until the upstream addresses this issue.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Aug 2, 2025
@nix-owners nix-owners bot requested a review from edwtjo August 2, 2025 18:51
@aoli-al
Copy link
Member Author

aoli-al commented Aug 2, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 430439

Logs: https://github.com/aoli-al/nixpkgs-review-gha/actions/runs/16696654706


x86_64-linux

✅ 4 packages built:
  • jetbrains.idea-community (jetbrains.idea-community-src)
  • jetbrains.jdk-no-jcef-17
  • jetbrains.jdk-no-jcef-17.debug
  • jetbrains.pycharm-community (jetbrains.pycharm-community-src)

aarch64-linux

✅ 4 packages built:
  • jetbrains.idea-community-src
  • jetbrains.jdk-no-jcef-17
  • jetbrains.jdk-no-jcef-17.debug
  • jetbrains.pycharm-community (jetbrains.pycharm-community-src)

@aoli-al aoli-al mentioned this pull request Aug 2, 2025
13 tasks
@adamcstephens adamcstephens added this pull request to the merge queue Dec 22, 2025
Merged via the queue into NixOS:master with commit 8311f5d Dec 22, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants