treewide: fix inappropriate usage of rust.envVars.setEnv#430368
Merged
LeSuisse merged 1 commit intoNixOS:masterfrom Nov 9, 2025
Merged
treewide: fix inappropriate usage of rust.envVars.setEnv#430368LeSuisse merged 1 commit intoNixOS:masterfrom
LeSuisse merged 1 commit intoNixOS:masterfrom
Conversation
It was designed for the Cargo build hook, which goes into `nativeBuildInputs`. Direct usage leads to an incorrect platform offset, which can for example be observed by the package `pkgsStatic.buildPackages` differing from the native one due to accidentally receiving the wrong environment variables. Fix the issue by using `buildPackages` as `nativeBuildInputs` would.
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Merged
13 tasks
nixpkgs-ci
bot
removed
the
9.needs: reviewer
Contributor
|
I can confirm that this fixes static builds of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was designed for the Cargo build hook, which goes into
nativeBuildInputs. Direct usage leads to an incorrect platform offset, which can for example be observed by the packagepkgsStatic.buildPackagesdiffering from the native one due to accidentally receiving the wrong environment variables. Fix the issue by usingbuildPackagesasnativeBuildInputswould.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.