cracklib: 2.10.0 -> 2.10.3: modernize & massively slim down#429797
Merged
K900 merged 1 commit intoNixOS:stagingfrom Aug 1, 2025
Merged
cracklib: 2.10.0 -> 2.10.3: modernize & massively slim down#429797K900 merged 1 commit intoNixOS:stagingfrom
K900 merged 1 commit intoNixOS:stagingfrom
Conversation
Use fetchFromGitHub to make the updateScript easier and avoid xz style supply chain issues. Separate into multiple outputs. The "out" output now doesn't have a bash dependency anymore because all the scripts are in "bin". Do not build the massive wordlist anymore. Instead rely on the built-in one. This is also what e.g. archlinux does and it leads to a massively smaller package: 10MiB -> 1MiB. This is especially dramatic/relevant because cracklib is in the mandatory NixOS system closure because it's a dependency of systemd. This change saves 9MiB transferred to literally every NixOS machine.
nikstur
force-pushed
the
modernize-cracklib-staging
branch
from
a9b44dc to
c1c1488
Compare
nikstur
changed the title
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
nikstur
added a commit
to nikstur/nixpkgs
that referenced
this pull request
Aug 10, 2025
Removes the dependency on bash. Increases the binary size by 2.3MiB. However, with the 9MiB saved by removing the excessive dictionary from cracklib (NixOS#429797), this still results in a net reduction of the mandatory closure size. Once kbd allows using the compression libraries instead of shelling out to the binaries (github.com/legionus/kbd/issues/138) we can compress by default again. Add the package `kbdCompressed` for users that want to load custom compressed fonts and keymaps. Alternatively, they can still uncompress custom fonts and keymaps themselves and then call loadkeys/setfont on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use fetchFromGitHub to make the updateScript easier and avoid xz style supply chain issues.
Separate into multiple outputs. The "out" output now doesn't have a bash dependency anymore because all the scripts are in "bin".
Do not build the massive wordlist anymore. Instead rely on the built-in one. This is also what e.g. archlinux does and it leads to a massively smaller package: 10MiB -> 1MiB. This is especially dramatic/relevant because cracklib is in the mandatory NixOS system closure because it's a dependency of systemd. This change saves 9MiB transferred to literally every NixOS machine.
This is also relevant for #428908
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.