Merged
Conversation
ofborg
bot
added
the
6.topic: cross-compilation
13 tasks
blitz
approved these changes
Jul 30, 2025
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
Member
Author
|
Right — had to also do the same fix in kernel/generic.nix. |
If we're going to use the unwrapped versions, we should do so consistently in both parts of the kernel build, not mix and match. Fixes: e9b2edb ("linux: un-simplify toolchain selection")
Contributor
|
i think something is broken- it used to work |
Member
|
Unwrapped bindgen is missing some libs. Using wrapped bindgen fixes building. $ make rustavailable
***
*** Running 'bindgen' to check the libclang version (used by the Rust
*** bindings generator) failed with code 101. This may be caused by
*** a failure to locate libclang. See output and docs below for details:
***
thread 'main' panicked at /build/rust-bindgen-unwrapped-0.72.0-vendor/bindgen-0.72.0/lib.rs:616:27:
Unable to find libclang: "couldn't find any valid shared libraries matching: ['libclang.so', 'libclang-*.so', 'libclang.so.*', 'libclang-*.so.*'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
***
***
*** Please see Documentation/rust/quick-start.rst for details
*** on how to set up the Rust support.
*** |
Member
Author
|
Yes, it is. I'm looking into it. Adding |
There's not really any reason for bindgen to dlopen libclang at all in Nixpkgs. Moving this out of the wrapper means that it will still work even when we don't want all the standard Nixpkgs cflags behavior, like in the Linux kernel build.
rustc.unwrapped is available, but it isn't spliced correctly. Having this attribute available at the top level is consistent with e.g. rust-bindgen-unwrapped.
The .unwrapped attributes are not correctly spliced. Use the top level attributes instead, which are spliced correctly. Fixes: e9b2edb ("linux: un-simplify toolchain selection")
nixpkgs-ci
bot
removed
the
11.by: package-maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .unwrapped attributes are not correctly spliced. Use the top level attributes instead, which are spliced correctly.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.