llvmPackages: drop libclc attributes that error#429382
Merged
alyssais merged 1 commit intoNixOS:masterfrom Jul 30, 2025
Merged
Conversation
13 tasks
nix-owners
bot
requested review from
Ericson2314,
dtzWill,
lovek323,
rrbutani and
sternenseemann
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nixpkgs-ci
bot
added
the
12.approvals: 1
libclc requires a compatible version of spirv-llvm-translator. If we don't have such a version, we get an eval error. This means that OfBorg builds of llvmPackages sets where libclc is unavailable will produce an eval error, which is very confusing. To fix this, restrict the libclc attribute to LLVM versions where it actually exists. Link: NixOS#414615 (comment)
alyssais
force-pushed
the
llvmPackages_20.libclc-drop
branch
from
58de27a to
09492fa
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libclc requires a compatible version of spirv-llvm-translator. If we don't have such a version, we get an eval error. This means that OfBorg builds of llvmPackages sets where libclc is unavailable will produce an eval error, which is very confusing. To fix this, restrict the libclc attribute to LLVM versions where it actually exists.
See #414615 (comment)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.