Skip to content

headlessDisplayHook: init#428552

Closed
qbisi wants to merge 2 commits intoNixOS:staging-nextfrom
qbisi:headlessDisplayHook
Closed

headlessDisplayHook: init#428552
qbisi wants to merge 2 commits intoNixOS:staging-nextfrom
qbisi:headlessDisplayHook

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented Jul 26, 2025 •
edited
Loading

add a headlessDisplayHook doing graphical check.
should fix https://hydra.nixos.org/build/303107238.

related pr: #423961

cc @vcunat @K900

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jul 26, 2025
@qbisi qbisi marked this pull request as ready for review July 26, 2025 09:07
@nix-owners nix-owners bot requested a review from OPNA2608 July 26, 2025 09:07
@Aleksanaa
Copy link
Member

Aleksanaa commented Jul 26, 2025

(Why it's targeting staging-next though)

@K900
Copy link
Contributor

K900 commented Jul 26, 2025

I need you to stop trying to make this hook happen. It's wrong and it won't happen.

K900
K900 requested changes Jul 26, 2025
View reviewed changes
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please identify the minimal change that actually fixes things - if it even does.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 26, 2025
@qbisi
Copy link
Contributor Author

qbisi commented Jul 26, 2025

It's wrong and it won't happen.

Can you specify the reason why it's wrong and won't happen. I have checked the output and build log, the graphical check do happen and passed.

@K900
Copy link
Contributor

K900 commented Jul 26, 2025

None of the XDG_ environment variables are relevant to this, neither is FONTCONFIG_FILE, and you need to clean up the Xvfb process after the tests are done if you want to run it like this. I'm 99% sure that the only thing actually relevant here is LD_LIBRARY_PATH, and if that's the case, it's a bug and we need to set rpath correctly wherever it's currently missing instead.

@K900 K900 mentioned this pull request Jul 26, 2025
Merged
13 tasks
@qbisi qbisi marked this pull request as draft July 26, 2025 11:59
@qbisi qbisi closed this Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@K900 K900 K900 requested changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@OPNA2608 OPNA2608 Awaiting requested review from OPNA2608

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qbisi @Aleksanaa @K900