Skip to content

gtk3: make x11Support actually disable X11 dependencies#428303

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
emilazy:push-mwkpknrzxlwq
Jul 25, 2025
Merged

gtk3: make x11Support actually disable X11 dependencies#428303
vcunat merged 1 commit intoNixOS:staging-nextfrom
emilazy:push-mwkpknrzxlwq

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Jul 25, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 25, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 25, 2025
@emilazy emilazy marked this pull request as ready for review July 25, 2025 12:52
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 25, 2025
@vcunat
Copy link
Member

vcunat commented Jul 25, 2025

Rebuild: linux 9485, darwin 10961

Uh, this is quite large at this point in staging-next.

@emilazy emilazy force-pushed the push-mwkpknrzxlwq branch from 6bb4933 to 1caf339 Compare July 25, 2025 16:25
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 25, 2025
@emilazy emilazy force-pushed the push-mwkpknrzxlwq branch from 1caf339 to 51cc2c3 Compare July 25, 2025 16:35
@emilazy emilazy force-pushed the push-mwkpknrzxlwq branch from 51cc2c3 to 549bbe1 Compare July 25, 2025 16:58
@emilazy emilazy changed the title gtk3: get X11 out of Darwin closure gtk3: make x11Support actually disable X11 dependencies Jul 25, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. and removed 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. labels Jul 25, 2025
@vcunat vcunat merged commit 285169c into NixOS:staging-next Jul 25, 2025
26 of 29 checks passed
@vcunat
Copy link
Member

vcunat commented Jul 25, 2025

This fixes the inkscape build on aarch64-darwin for me.

@vcunat vcunat mentioned this pull request Jul 25, 2025
Merged
13 tasks
@emilazy emilazy deleted the push-mwkpknrzxlwq branch July 25, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@dasj19 dasj19 Awaiting requested review from dasj19

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilazy @vcunat