Skip to content

linux-rpi: fix eval on darwin#428023

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-eval-asserts-linux
Jul 24, 2025
Merged

linux-rpi: fix eval on darwin#428023
wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-eval-asserts-linux

Conversation

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Jul 24, 2025 •
edited
Loading

meta.platforms should only contain Linux platforms.

Fixes #427219 (comment).

Hopefully this is enough and there are no other eval failures hiding for us.

Closes #427877.

Things done

Add a 👍 reaction to pull requests you find important.

@wolfgangwalther
linux-rpi: fix eval on darwin
172db2e 
`meta.platforms` should only contain Linux platforms.
@wolfgangwalther wolfgangwalther requested a review from vcunat July 24, 2025 11:20
@wolfgangwalther wolfgangwalther mentioned this pull request Jul 24, 2025
Merged
1 task
@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Jul 24, 2025

At least there don't seem to be similar errors in the linux/kernel part:

% rg 'platforms =' pkgs/os-specific/linux/kernel
pkgs/os-specific/linux/kernel/manual-config.nix
526:          platforms = platforms.linux;

pkgs/os-specific/linux/kernel/linux-rpi.nix
46:            platforms = with lib.platforms; lib.intersectLists arm linux;
51:            platforms = with lib.platforms; lib.intersectLists (arm ++ aarch64) linux;

pkgs/os-specific/linux/kernel/perf/default.nix
213:    platforms = platforms.linux;

pkgs/os-specific/linux/kernel/htmldocs.nix
54:    platforms = lib.platforms.linux;

pkgs/os-specific/linux/kernel/gpio-utils.nix
27:    platforms = platforms.linux;

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 24, 2025
@ryand56
Copy link
Member

ryand56 commented Jul 24, 2025

Will also fix #427877.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: kernel The Linux kernel labels Jul 24, 2025
@wolfgangwalther wolfgangwalther merged commit b55d445 into NixOS:master Jul 24, 2025
30 of 33 checks passed
@wolfgangwalther wolfgangwalther deleted the ci-eval-asserts-linux branch July 24, 2025 11:56
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jul 24, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jul 24, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 24, 2025
@MattSturgeon MattSturgeon mentioned this pull request Jul 24, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat Awaiting requested review from vcunat

@TredwellGit TredwellGit Awaiting requested review from TredwellGit

@Ma27 Ma27 Awaiting requested review from Ma27

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@alyssais alyssais Awaiting requested review from alyssais

@K900 K900 Awaiting requested review from K900

Assignees

No one assigned

Labels

1.severity: channel blocker Blocks a channel 6.topic: darwin Running or building packages on Darwin 6.topic: kernel The Linux kernel 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linux-rpi: stable_20250702 update breaks nixpkgs-review on aarch64-darwin

3 participants

@wolfgangwalther @ryand56 @vcunat