systemd: v257.9 -> v258#427968
Conversation
|
258 has been released! |
|
Can this go to staging before #440130, so it rebuilds only once? |
401fb33 to
e2a77e2
Compare
|
Regression in journald has been reported here: systemd/systemd#39057 |
|
note that this is apparently fixing an IMO serious resolved problem systemd/systemd#38951 |
e2a77e2 to
bb2e732
Compare
bb2e732 to
bb4944e
Compare
|
I've been trying to build my system with this PR. Notes so far:
|
bb4944e to
174b721
Compare
|
@philiptaron Looks like I'm putting on the last finishing touches and running the tests, once that's done I think this will be good to go. |
It's unclear why we didn't get the error message about this binary not existing before, because the udev rule requiring it has always been in systemd initrd.
7c356fa to
8ec0a3a
Compare
|
Do you think you could integrate the |
This ordering is present in the upstream unit in 258
8ec0a3a to
6160af2
Compare
|
Oh whoops, I saw you already added a closed link to the other PR. I closed it before I noticed that. |
|
FYI, I think tomorrow is the last day to merge if you want this in 25.11? Sources: |
|
I think this has to do with the removal of I'm fine with dropping the option from the module |
This comment was marked as outdated.
This comment was marked as outdated.
Systemd wants you to run tpm unlock on a machine with the TCG bits of OVMF enabled. If not it just bails out with No TPM2 hardware discovered and EFI firmware does not see it either, falling back to traditional unlocking
it's not an official systemd thing and we're not the maintainers of it. Also the test is broken. But that is not our problem
|
Alright I tested this on |
`vhost-device-vsock`[1] is a custom implementation of AF_VSOCK, but the application on the host-side uses a UNIX domain-socket. This gives us the following nice properties: * We don't need to do `--arg sandbox-paths /dev/vhost-vsock` anymore for debugging builds within the sandbox. That means, untrusted users can also debug these kinds of tests now. * This prevents CID conflicts on the host-side, i.e. there's no need for using `sshBackdoor.vsockOffset` for tests anymore. A big shout-out goes to Allison Karlitskaya, the developer of test.thing[2] who talked about this approach to do AF_VSOCK on All Systems Go 2025. This patch requires systemd 258[3] because this contains `vhost-mux` in its SSH config which is needed to connect to the VMs from now on. To not blow up the patches even more, this only uses AF_VSOCK for the debugger. A potential follow-up for the future would be a removal of the current `backdoor.service` and replace it entirely by this functionality. The internal implementation tries to be consistent with how VLANs and machines are handled, i.e. the processes are started when the Driver's context is entered and cleaned up in __exit__(). I decided to push the process management and creation of sockets for vhost-device-vsock into its own class, that's an implementation detail and not a concern for the test-driver. In fact, `vhost-device-vsock` is something we can drop once QEMU implements native support for using AF_UNIX on the host-side[4]. `VsockPair` is its own class since returning e.g. a triple of `(Path, Path, Int)` would be ambiguous in what is the guest and what the host path (and frankly, I found it hard to distinguish the two when reading the docs of `vhost-device-vsock` initially). Finally, now that we can do the SSH backdoor without adding additional devices to the sandbox, I figured, it's time to write a test-case for it. [1] https://github.com/rust-vmm/vhost-device/blob/main/vhost-device-vsock/README.md [2] https://codeberg.org/lis/test.thing [3] NixOS#427968 [4] https://gitlab.com/qemu-project/qemu/-/issues/2095
Closes #441918
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.