python3Packages.imageio: fix build, enable most tests#427800
Merged
philiptaron merged 1 commit intoNixOS:staging-nextfrom Jul 24, 2025
Merged
python3Packages.imageio: fix build, enable most tests#427800philiptaron merged 1 commit intoNixOS:staging-nextfrom
philiptaron merged 1 commit intoNixOS:staging-nextfrom
Conversation
philiptaron
requested review from
ShamrockLee,
Shawn8901,
mweinelt and
wolfgangwalther
13 tasks
philiptaron
force-pushed
the
fix-python3Packages.imageio
branch
from
1fcfafd to
69b62cb
Compare
...elopment/python-modules/imageio/0001-tests-switch-to-a-local-git-repository-by-default.patch
Outdated
Show resolved
Hide resolved
...pment/python-modules/imageio/0003-tests-replace-libgl-runtime-lookup-with-build-time-l.patch
Outdated
Show resolved
Hide resolved
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
philiptaron
force-pushed
the
fix-python3Packages.imageio
branch
from
69b62cb to
5247514
Compare
Shawn8901
reviewed
Jul 23, 2025
...elopment/python-modules/imageio/0001-tests-switch-to-a-local-git-repository-by-default.patch
Outdated
Show resolved
Hide resolved
.../development/python-modules/imageio/0002-tests-mark-more-tests-as-needing-the-internet.patch
Outdated
Show resolved
Hide resolved
philiptaron
force-pushed
the
fix-python3Packages.imageio
branch
from
5247514 to
f5deb48
Compare
With 6248978, the new parenthesization logic exposes a coding defect in `imageio` where they do a string test vs. `"not needs_internet"` instead of something parsed. Instead of fixing that, we can actually enable almost all of the tests in this module with a command-line flag which points to a FOD of https://github.com/imageio/test_images repository. There are a few more tests that need to be disabled as well; I opened a PR against imageio to fix these. I also removed the `libgl-path.patch` in favor of a simple `--replace-fail`.
philiptaron
force-pushed
the
fix-python3Packages.imageio
branch
from
f5deb48 to
ffa9e79
Compare
Contributor
Author
|
OK, I'm hands-off now. I think this is good to merge. |
wolfgangwalther
approved these changes
Jul 24, 2025
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 427800 --package python3Packages.imageio
Commit: ffa9e79f29257b23cfefafb7ff036438b9068e2c
x86_64-linux
✅ 2 packages built:
- python3Packages.imageio
- python3Packages.imageio.dist (python3Packages.imageio.dist.dist)
Thank you!
nixpkgs-ci
bot
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 6248978 (reported here), the new parenthesization logic exposes a coding defect in
imageiowhere they do a string test vs."not needs_internet"instead of something parsed.Instead of fixing that, we can actually enable almost all of the tests in this module with a new patch which downloads the https://github.com/imageio/test_images repository and provides it to the test suite.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.