Conversation
|
Hm, we have a problem on this pin, because nix 2.3 has been marked insecure in #420974. This means it's not cached anymore. I guess we'll have to drop it from the parse check. |
|
@sternenseemann @tazjin could you chime in on what the plans / progress are for backporting the recent CVE patches to Nix 2.3? We have multiple options here:
In case we drop Nix 2.3, we can't prevent nix 2.3-incompatible syntax from sneaking in anymore and should raise the minimum required nix version to evaluate nixpkgs. IIRC, this will also allow us to remove some cruft around structuredAttrs, because we'll be able to drop support for many intermediate versions, where fixes for that were not backported. |
b6d78ae to
9fb327d
Compare
|
I guess the reformat should also be added to |
Yes, but I'd like to do this in a follow up. I'm sure I'll need to rebase a bit more, and don't want to have a wrong hash in there. Been there before elsewhere. |
I looked into this a bit more.
Since we surely don't want to block this PR / updates to CI indefinitely, I will do the following:
|
Fixes all code blocks with "nix" language in markdown files for syntax errors to be able to run nixfmt in the next step.
Those had been misplaced by nixfmt.
Nix 2.3 is marked as insecure and thus not cached anymore. We'll either need to patch it and cache it again or drop it.
This gives us Nix 2.30 and nixfmt 1.0.0. From the nixpkgs-unstable channel: https://hydra.nixos.org/eval/1817034#tabs-inputs Changes for treefmt-nix: numtide/treefmt-nix@a05be41...421b563
8ba3643 to
5a07111
Compare
|
Rebased and resolved merge conflicts. Not keen on more of them, so let's get this done. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I will now do all the periodic merges to resolve the arising conflicts. Edit: For the curious, I am using the approach outlined in #395864, aka the custom git merge driver. |
|
Backport in #428039. |
|
I did the following:
Each merge was done with the custom merge driver and then amended with another run of All development branches are now formatted with nixfmt 1.0.0! |
|
Thanks for handling this! Really happy to see the concatenation change land. Are you going to handle adding all of those to |
|
Yes, on my list. |
This gives us Nix 2.30 and nixfmt 1.0.0.
From the nixpkgs-unstable channel:
https://hydra.nixos.org/eval/1817034#tabs-inputs
Changes for treefmt-nix:
numtide/treefmt-nix@a05be41...421b563
Things done
Add a 👍 reaction to pull requests you find important.