Skip to content

workflows/build: build nixpkgs tarball#427434

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-tarball
Jul 24, 2025
Merged

workflows/build: build nixpkgs tarball#427434
wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-tarball

Conversation

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Jul 22, 2025

This adds a build job for the tarball, which might help uncover eval issues on attributes not normally touched by Eval, aka those added in pkgs/top-level/packages-config.nix.

Resolves #393430.

Things done


Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs backport release-25.05 labels Jul 22, 2025
@wolfgangwalther wolfgangwalther mentioned this pull request Jul 22, 2025
1 task
@wolfgangwalther wolfgangwalther marked this pull request as ready for review July 22, 2025 15:04
@MattSturgeon
Copy link
Contributor

Should this close #406825 ?

@wolfgangwalther
Copy link
Contributor Author

Should this close #406825 ?

No, that's different. The discussion in #393430 went two ways: tarball and release-checks. The latter was then separated from that issue again, so this PR only addresses the former.

Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept and diff LGTM, pending the blockers mentioned in the description.

@wolfgangwalther
Copy link
Contributor Author

pending the blockers mentioned in the description.

The update for the pin is not needed anymore, because we don't need to use Nix 2.30 for it. Lix is equally fast, it's only Nix 2.28 and 2.29 that are slow (I did not test 2.24).

Thus, I don't consider there to be any blockers right now.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 23, 2025
This adds a build job for the tarball, which might help uncover eval
issues on attributes not normally touched by Eval, aka those added in
`pkgs/top-level/packages-config.nix`.
@wolfgangwalther wolfgangwalther merged commit ee63cb8 into NixOS:master Jul 24, 2025
43 of 46 checks passed
@wolfgangwalther wolfgangwalther deleted the ci-tarball branch July 24, 2025 10:33
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jul 24, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Actions eval still doesn’t check every channel‐blocking eval issue

2 participants