various: move throws to aliases#426639
Conversation
nix-owners
bot
requested review from
maralorn,
mweinelt,
natsukium and
sternenseemann
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nixpkgs-ci
bot
added
the
12.approvals: 1
nixpkgs-ci
bot
added
12.approvals: 2
wolfgangwalther
force-pushed
the
ci-eval-asserts-aliases
branch
from
1ded1de to
4e5ff45
Compare
|
Why the removal of the older versions of Magma? |
|
As the commit message says: When I try to eval them, I get this error: Thus, my understanding is that they are already dead effectively, since ROCm 5.7 was removed. Thus, I just turn them into aliases - they already throw anyway. Is my understanding wrong? Can these still be sensibly used? |
|
They can, they still build with CUDA -- those eval failures should only occur if ROCm support is enabled. However, the only consumer of Magma in-tree is PyTorch, and IIRC it only builds with the latest... so I suppose the removal is actually for the best :) |
Ah, OK, I see. If we were to keep them, we'd have to either mark them as broken conditionally or do something like #426645 ...
... but dropping them is much easier. I reflected that in the commit message, which is now |
wolfgangwalther
force-pushed
the
ci-eval-asserts-aliases
branch
from
4e5ff45 to
0cd0bb4
Compare
|
+1 for dropping older magma, but the throw message should read something like |
wolfgangwalther
force-pushed
the
ci-eval-asserts-aliases
branch
from
0cd0bb4 to
67b0c70
Compare
Makes sense, changed accordingly. I also went through magma's generic builder and removed all conditionals for older than the currently only packaged version. If you want to keep any of that, I can revert things there. Let me know. (another force push fixed treefmt) |
These throw this error on eval right now: ``` the required ROCm 5.7 version for magma 2.6.2 has been removed ``` They'd technically be usable with CUDA, but are not used in-tree.
This had already been removed and should be an alias now.
This is required to make CI work properly.
Same reasoning as commits before.
wolfgangwalther
force-pushed
the
ci-eval-asserts-aliases
branch
from
67b0c70 to
1d4e069
Compare
nixpkgs-ci
bot
added
12.approvals: 3+
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
6 participants
In some cases we throw for already removed packages. These should only be there with aliases enabled. This helps when generating all attrpaths for evaluation in CI.
Part of #426629, ultimately targeting #397184.
Things done
Add a 👍 reaction to pull requests you find important.