Skip to content

libtiff: Apply patch to fix test_directory test on big-endian#426618

Merged
imincik merged 1 commit intoNixOS:stagingfrom
OPNA2608:fix/libtiff-tests-big-endian
Aug 25, 2025
Merged

libtiff: Apply patch to fix test_directory test on big-endian#426618
imincik merged 1 commit intoNixOS:stagingfrom
OPNA2608:fix/libtiff-tests-big-endian

Conversation

@OPNA2608
Copy link
Contributor

Fixes:

        Start  12: test_directory
 12/155 Test  #12: test_directory .......................................................................***Failed    0.14 sec
-- Running  /build/source/build/test/test_directory

[...]

--- Test for test_current_dirnum_incrementing non-BigTIFF and BE testcase 0. ---
TIFFRewriteDirectory: Error fetching directory link.
----- Expect some error messages about 'scanline size is zero' -----
TIFFScanlineSize64: Computed scanline size is zero.
TIFFScanlineSize64: Computed scanline size is zero.
TIFFReadDirectory: Cannot handle zero scanline size.
TIFFScanlineSize64: Computed scanline size is zero.
TIFFReadDirectory: Cannot handle zero scanline size.
TIFFScanlineSize64: Computed scanline size is zero.
TIFFReadDirectory: Cannot handle zero scanline size.
----- Expect error messages about 'Sanity check AND Failed to read directory' -----
TIFFFetchDirectory: Sanity check on directory count failed, this is probably not a valid IFD offset.
TIFFReadDirectory: Failed to read directory at offset 10.
----- Expect error messages about 'Error fetching directory link.' -----
TIFFAdvanceDirectory: /build/source/libtiff/tif_dir.c:1953: test_current_dirnum_incrementing_wb.tif: Error fetching directory count.
----- Expect error messages about 'Cannot read TIFF directory.' -----
test_current_dirnum_incrementing_wb.tif: Failed to allocate memory for to read TIFF directory (0 elements of 12 bytes each).
TIFFReadDirectory: Failed to read directory at offset 458.
----- Expect error messages about 'Error fetching directory link.' -----
TIFFAdvanceDirectory: /build/source/libtiff/tif_dir.c:1953: test_current_dirnum_incrementing_wb.tif: Error fetching directory count.
----- Expect error messages about 'Failed to allocate memory for to read TIFF directory.' AND 'Failed to read directory ..' -----
TIFFReadDirectory: Warning, Unknown field with tag 1 (0x1) encountered.
MissingRequired: TIFF directory is missing required "ImageLength" field.
Error: curdir 3 is different to expected one -1 at line 2048
Failed during Current Directory Number Incrementing test #0 in non-BigTIFF and BE.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • powerpc64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and others READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 19, 2025
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested; LGTM, thanks!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 24, 2025
Copy link
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@imincik imincik merged commit 2a0169e into NixOS:staging Aug 25, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants