Skip to content

{python3Packages.,}monosat: modernize#426471

Merged
marcin-serwin merged 1 commit intoNixOS:masterfrom
TomaSajt:monosat
Feb 17, 2026
Merged

{python3Packages.,}monosat: modernize#426471
marcin-serwin merged 1 commit intoNixOS:masterfrom
TomaSajt:monosat

Conversation

@TomaSajt
Copy link
Contributor

Changed --replace to --replace-fail
Used lib.cmakeBool instead of the custom helper function.
Used env. for env vars.
Added pythonImportsCheck
Used pyproject = true instead of the legacy format = "setuptools"
I did not convert sha256 to hash.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and others READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium July 18, 2025 19:49
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 18, 2025
@nix-owners nix-owners bot requested a review from acairncross July 18, 2025 19:54
Copy link
Contributor

@acairncross acairncross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 19, 2025
repo = "monosat";
inherit rev sha256;
tag = version;
sha256 = "0q3a8x3iih25xkp2bm842sm2hxlb8hxlls4qmvj7vzwrh4lvsl7b";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to use SRI hash here

@iedame iedame mentioned this pull request Oct 25, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 5, 2025
@TomaSajt TomaSajt closed this Jan 20, 2026
@TomaSajt TomaSajt deleted the monosat branch January 20, 2026 18:42
@TomaSajt TomaSajt restored the monosat branch January 20, 2026 18:50
@TomaSajt TomaSajt reopened this Jan 20, 2026
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 20, 2026
Copy link
Contributor

@marcin-serwin marcin-serwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on aarch64-linux

@marcin-serwin marcin-serwin added this pull request to the merge queue Feb 17, 2026
Merged via the queue into NixOS:master with commit 2a08853 Feb 17, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants