jetbrains.jdk*: Update Jetbrains Java Runtime packages #426285
jetbrains.jdk*: Update Jetbrains Java Runtime packages #426285fabianhjr merged 2 commits intoNixOS:masterfrom
Conversation
acid-bong
left a comment
There was a problem hiding this comment.
Rename the PR and all commits according to conventions (the docs are linked at the end of the checklist)
|
Thanks! Edit: A segfault happened while checking a Jupyter file. Previous success was due to caching? At this point I think it's an unrelated issue, but it would be better if other users could confirm or deny this. Details |
The main reason I created a new PR is because I believe the changes in #425529 to be a bit too invasive. I'm not sure why there is a block which skips the I'm not strictly against combining these PR's, but I think the changes in this PR don't actually require the changes in #425529 |
c7ca5e4 to
7687391
Compare
Honestly no idea. I'd blame this on JCEF, but to be fair, I think we're also mixing a combination of JCEF and JBR that is not how upstream combines the versions. It would be interesting to see the |
|
@acid-bong I'm not entirely sure if the commit messages and PR title are now ok, especially the ones which touch multiple packages. Maybe you have a better idea on naming them |
|
I also got segfault while trying to open a markdown file using idea-community-bin. This might be related: https://youtrack.jetbrains.com/issue/JBR-8199/PyCharm-Crashes-with-2024.3.2 and https://youtrack.jetbrains.com/issue/JBR-5948/Intellij-crash-at-C-libstdc.so.60xd2194-stdcodecvtutf8utf16basechar16tdounshift |
|
Does the workaround help? I couldn't yet reproduce this. I would declare this a Jetbrains issue to be open, though chances are this could be solved by updating the used JCEF (and maybe building the CEF binaries from source, they are currently downloaded pre-built and then patched) |
I can't test workaround or help with this PR any further due to being away from my main PC, however here are several important details: Before attempting to reproduce this issue on any project, make sure you remove the jcef cache (for example I didn't remove the cache while checking this PR, so it probably segfaults too. And another one is confirmed to segfault. This is very unlikely to be a JetBrains issue. It happens with both old and new jbr-jcef when: I guess having both set to true has the side effect of changing some sneaky environment variable (no idea which one) during building process and that causes segfault later. For now I've overridden both to false: And everything works as expected. |
|
Oh great... maybe this really is the way then, even if its quick and dirty. I have the feeling figuring out why JCEF randomly segfaults is a not insubstantial amount of work. |
I didn't try to change the permission of the
idea-community-bin does not segfault with #425529 even after the |
|
Rebased after merging #425529 |
|
Had to repush due to a nix fmt error: https://github.com/NixOS/nixpkgs/actions/runs/16505373386/job/46674511731 |
aoli-al
left a comment
There was a problem hiding this comment.
Tried linux-x86 and everything works for me. Thanks for keeping the ball rolling.
|
Things done
jetbrains.jdk-17-*tojb17.0.15-b1381jetbrains.jdktojb21.0.7-b1038.58This also fixes the build failures introduced by 4f3fd5b, at least on x86_64.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Prior Art
This PR should in theory supersede #425529 and #425814. #419026 also attempts to fix the runtime while upgrading other jetbrains packages.
I believe the approach in this PR is the "most-correct" and minimally invasive one with the added benefit of upgrading the Jetbrains runtime packages to newer versions.
Add a 👍 reaction to pull requests you find important.