stalwart-mail: fix 16 KB page size on ARM systems#426090
Merged
emilazy merged 1 commit intoNixOS:masterfrom Aug 3, 2025
Merged
stalwart-mail: fix 16 KB page size on ARM systems#426090emilazy merged 1 commit intoNixOS:masterfrom
emilazy merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Pandapip1
reviewed
Jul 17, 2025
nixpkgs-ci
bot
removed
the
12.first-time contribution
Contributor
|
Can someone take a look? Would be bummer if other PRs will collide with this change, it's just aligning with the upstream packaging. @happysalada 🙏🏼 Previous attempts to resolve jmalloc issues on ARM were using the
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
emilazy
dismissed
their stale review
Sorry, should have read the whole discussion and not just the diff…
emilazy
approved these changes
Aug 3, 2025
Member
|
We should ideally match our nixpkgs/pkgs/development/libraries/jemalloc/default.nix Lines 71 to 81 in 4770c46 But this is an improvement, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stalwart-mail on ARMv7 and Aarch64 systems with a 16 KB page size. Previously, stalwart-mail could not start on an ARM system with a page size bigger than 4 KB. This environment variable should not break compatibility with smaller page sizes.
The official stalwart-mail CI does this as well: https://github.com/stalwartlabs/stalwart/blob/4f84533fa1a061dbcde8fad2cc100f1f92d650a6/.github/workflows/ci.yml#L125
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.