Skip to content

python310Packages.numpy: disable#425967

Merged
wegank merged 1 commit intoNixOS:masterfrom
dotlambda:python3Packages.numpy
Jul 17, 2025
Merged

python310Packages.numpy: disable#425967
wegank merged 1 commit intoNixOS:masterfrom
dotlambda:python3Packages.numpy

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Jul 17, 2025

closes #425456

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda requested a review from doronbehar July 17, 2025 01:35
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 17, 2025
wegank
wegank approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@wegank wegank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as upstream does not support Python 3.10.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 17, 2025
doronbehar
doronbehar approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer the commit message python310Packages.numpy: disable, but other then that LGTM.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 17, 2025
@doronbehar doronbehar mentioned this pull request Jul 17, 2025
Merged
11 tasks
@wegank wegank force-pushed the python3Packages.numpy branch from a4390bd to f4ae1d9 Compare July 17, 2025 15:24
@wegank wegank changed the title python3Packages.numpy: requires Python >= 3.11 python310Packages.numpy: disable Jul 17, 2025
@wegank wegank merged commit 0fb8ea8 into NixOS:master Jul 17, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: python310Packages.numpy

3 participants

@dotlambda @wegank @doronbehar