Skip to content

python311Packages.scipy: fix build by disabling a test#425900

Merged
wegank merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/scipy@Py311
Jul 19, 2025
Merged

python311Packages.scipy: fix build by disabling a test#425900
wegank merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/scipy@Py311

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jul 16, 2025

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@doronbehar doronbehar mentioned this pull request Jul 16, 2025
Closed
3 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 16, 2025
@mweinelt
Copy link
Member

mweinelt commented Jul 16, 2025 •
edited
Loading

Feel free to disable numpy on 3.10 (and older).

meson-python: error: The package requires Python version >=3.11, running on 3.10.18

It blocks the scipy build there.

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 16, 2025
@doronbehar
Copy link
Contributor Author

doronbehar commented Jul 16, 2025

Feel free to disable numpy on 3.10 (and older).

I don't understand.. Why would I do that? I suspect there's a mistake here.

@mweinelt
Copy link
Member

mweinelt commented Jul 16, 2025

The numpy version we have is not compatible with 3.10, so it is fine to disable because we won't reintroduce a compatible version any more.

Numpy is a dependency of scipy, so it blocks the build of python310Packages.scipy, which is why it is related.

@doronbehar
Copy link
Contributor Author

doronbehar commented Jul 17, 2025

Numpy is a dependency of scipy, so it blocks the build of python310Packages.scipy, which is why it is related.

OK I understand, but this PR is about python311Packages.scipy, not python310Packages.scipy.

@mweinelt
Copy link
Member

mweinelt commented Jul 17, 2025

Hence me opening with "Feel free".

@doronbehar
Copy link
Contributor Author

doronbehar commented Jul 17, 2025

Feel free to disable numpy on 3.10 (and older).

OK I see. Maybe the word 'also' could have helped here :). I also was a confused because exactly this was already happening on:

I get from this that you approve this change here?

@ccicnce113424 ccicnce113424 mentioned this pull request Jul 18, 2025
Closed
3 tasks
@wegank wegank merged commit 5939a78 into NixOS:master Jul 19, 2025
30 of 31 checks passed
@doronbehar doronbehar deleted the pkg/scipy@Py311 branch February 10, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doronbehar @mweinelt @wegank