Conversation
JohnRTitor
left a comment
There was a problem hiding this comment.
[johnrtitor@build01:~]$ nix build github:nixos/nixpkgs/refs/pull/425382/merge#open-webui --print-out-paths --impure
error: builder for '/nix/store/gmpl4s1drn2qy2awr911m4s72k6vrsl2-python3.13-pgvector-0.4.1.drv' failed with exit code 1;
last 25 log lines:
> Finished executing pypaInstallPhase
> Running phase: pythonOutputDistPhase
> Executing pythonOutputDistPhase
> Finished executing pythonOutputDistPhase
> Running phase: fixupPhase
> shrinking RPATHs of ELF executables and libraries in /nix/store/vzgkb4cilwgar7sh6nhfqxznfr7v5i9k-python3.13-pgvector-0.4.1
> checking for references to /build/ in /nix/store/vzgkb4cilwgar7sh6nhfqxznfr7v5i9k-python3.13-pgvector-0.4.1...
> patching script interpreter paths in /nix/store/vzgkb4cilwgar7sh6nhfqxznfr7v5i9k-python3.13-pgvector-0.4.1
> stripping (with command strip and flags -S -p) in /nix/store/vzgkb4cilwgar7sh6nhfqxznfr7v5i9k-python3.13-pgvector-0.4.1/lib
> shrinking RPATHs of ELF executables and libraries in /nix/store/if193f28j7c8kh3gpnb7c1nv8wqnwvbr-python3.13-pgvector-0.4.1-dist
> checking for references to /build/ in /nix/store/if193f28j7c8kh3gpnb7c1nv8wqnwvbr-python3.13-pgvector-0.4.1-dist...
> patching script interpreter paths in /nix/store/if193f28j7c8kh3gpnb7c1nv8wqnwvbr-python3.13-pgvector-0.4.1-dist
> Executing pythonRemoveTestsDir
> Finished executing pythonRemoveTestsDir
> Running phase: installCheckPhase
> no Makefile or custom installCheckPhase, doing nothing
> Running phase: pythonCatchConflictsPhase
> Running phase: pythonRemoveBinBytecodePhase
> Running phase: pythonImportsCheckPhase
> Executing pythonImportsCheckPhase
> Check whether the following modules can be imported: pgvector
> Running phase: pytestCheckPhase
> Executing pytestCheckPhase
> /nix/store/04xc8i3h5qvbl17fm6dw9dfk3ls0fi5b-postgresql-test-hook/nix-support/setup-hook: line 52: type: initdb: not found
> initdb not found. Did you add postgresql to the nativeCheckInputs?
For full logs, run:
nix log /nix/store/gmpl4s1drn2qy2awr911m4s72k6vrsl2-python3.13-pgvector-0.4.1.drv
warning: killing stray builder process 628025 ()...
error: 1 dependencies of derivation '/nix/store/n7kadcz6y6gbzixxd5987a6lr18k81xj-open-webui-0.6.16.drv' failed to build
|
Note that this is also broken on master/nixos-unstable. |
|
Ahh, #425384 |
Cherry picked commits from 1. NixOS/nixpkgs#425384 2. NixOS/nixpkgs#425382 Signed-off-by: John Titor <[email protected]>
JohnRTitor
left a comment
There was a problem hiding this comment.
┃ error: undefined variable 'ddgs'
┃ at /nix/store/hjfh8f81m0mrjk3gd6rdhwpjaj2r0rln-source/pkgs/by-name/op/open-webui/package.nix:112:7:
┃ 111| cryptography
┃ 112| ddgs
┃ | ^
┃ 113| docx2txt
┣━━━
bd11fd7 to
402394b
Compare
|
Have you tested it ? |
|
@lostmsu Have you tested it before approving it? |
|
@drupol no, I assumed it builds -> it will work since the change should not be major. But it sounds like pgvector was still broken. You might want to rebase on a commit from master that includes the pgvector check bypass. |
My experience in IT has taught me to never assume anything. This applies even more in
Precisely. That’s why approving this PR at this point doesn’t seem like a good idea.
I will, thanks for the suggestion. |
402394b to
e634674
Compare
|
Yes, an increasing number of maintainers/developers have been using the "zero space" pattern you mentioned, even though their software is technically stable defacto and dejure. I personally think we should root for semantic versioning, and use it the proper way. |
At least in an overlay build failsThis sounds the most problematic: 7:55:37 PM [vite-plugin-svelte] /build/source/src/routes/(app)/notes/+page.svelte:53:9 'showArchivedChats' is not defined 51: on:show={(e) => {
52: if (e.detail === 'archived-chat') {
53: showArchivedChats.set(true);
^
54: }
55: }}Unfortunately the output does not make distinction between warnings and errors, and it is unclear what exactly is treated as error. |
|
Diff: open-webui/open-webui@refs/tags/v0.6.15...refs/tags/v0.6.16
Changelog: https://github.com/open-webui/open-webui/blob/v0.6.16/CHANGELOG.md
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.