Skip to content

dbus-test-runner: use regular gettext to fix build#424796

Merged
K900 merged 1 commit intoNixOS:staging-nextfrom
LordGrimmauld:dbus-test-runner-gettext
Jul 13, 2025
Merged

dbus-test-runner: use regular gettext to fix build#424796
K900 merged 1 commit intoNixOS:staging-nextfrom
LordGrimmauld:dbus-test-runner-gettext

Conversation

@LordGrimmauld
Copy link
Contributor

glib gettext is deprecated and currently broken. This fixes the build by using regular gettext instead.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

`glib` gettext is deprecated and currently broken.
This fixes the build by using regular gettext instead.
@LordGrimmauld LordGrimmauld requested review from K900 and alyssais July 13, 2025 10:07
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jul 13, 2025
@K900 K900 merged commit 1036053 into NixOS:staging-next Jul 13, 2025
25 of 29 checks passed
@nix-owners nix-owners bot requested a review from OPNA2608 July 13, 2025 10:11
@alyssais
Copy link
Member

Upstream? Doesn't look very active but the recent merge proposal was accepted, so maybe that's just because it's mostly done?

@LordGrimmauld
Copy link
Contributor Author

its launchpad, i don't have an account upstream (and am not particularly keen on creating one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants