lixPackageSets.git: 2.94.0-pre-20250704_362bfd827f52 -> 2.94.0-pre-20250711_ae00b1298353#424775
Conversation
lf-
left a comment
There was a problem hiding this comment.
hilarious bug. I've stamped the upstream fix so you could probably submit that and then upgrade past the bug to not have to deal with it here
1e075d3 to
4bc7b90
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
|
|
I cannot reproduce these failures and they look very similar to https://git.lix.systems/lix-project/lix/issues/545 . Are you building on Ubuntu? |
4bc7b90 to
0119645
Compare
|
Static build still doesn't work due to cmake failure when trying to find toml11. |
|
Marking as ready for review again since the failure already happens on the base so this update doesn't make anything worse. Of course it would still be good to fix the issue. Relevant excerpt from the CMake logs embedded in the Meson logs: It seems like somehow it tries to link against the wrong libgcc. |
|
Bisected with |
0119645 to
f239c7f
Compare
|
Bisected without The likely cause here is 24cd084 which enables |
lf-
left a comment
There was a problem hiding this comment.
overall lgtm, confused at why we want to skip structured attrs
There was a problem hiding this comment.
oops i read the commit message. please add a comment because this is would otherwise be baffling
There was a problem hiding this comment.
Because it is the thing that broke static builds. I will continue debugging this.
|
@symphorien could we have your help for the static builds as you landed the structured attrs change? You may have a hint to what's going on. |
7d05b29 to
b3c6030
Compare
|
The install checks now hard-depend on |
|
Static build fails on |
b3c6030 to
9c8cca6
Compare
|
|
|
Is this ready to merge? |
|
From the author perspective yes (otherwise I would have marked as draft). |
Due to the wrong platform offset, buildPackages.capnproto would inappropriately depend on empty-libgcc_eh when building with dynamic build platform and static host platform. In turn the build would fail due to the archiver not being found.
…thonOnBuildForHost The former seems to exhibit fewer subtle issues breaking cross (in particular static) builds, for reasons I have not yet understood.
9c8cca6 to
722ef72
Compare
|
Static build doesn't work again due to kj fibers, but again it was broken before. |
…250807_8bbd5e1d0df9
722ef72 to
28a8bb1
Compare
|
|
|
Successfully created backport PR for |
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.