Skip to content

[staging-next] git-annex: apply workaround for test failure with git 2.50#424682

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
sternenseemann:gi--annex-git-2.50
Jul 13, 2025
Merged

[staging-next] git-annex: apply workaround for test failure with git 2.50#424682
vcunat merged 1 commit intoNixOS:staging-nextfrom
sternenseemann:gi--annex-git-2.50

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Jul 12, 2025

The next haskellPackages bulk update will also resolve this, but picking the patch will prevent a broken git-annex until the next staging-next is merged into master.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

The next haskellPackages bulk update will also resolve this, but picking
the patch will prevent a broken git-annex until the next staging-next is
merged into master.
@nix-owners nix-owners bot requested review from maralorn and wolfgangwalther July 12, 2025 21:28
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Jul 12, 2025
@vcunat vcunat merged commit f9766b6 into NixOS:staging-next Jul 13, 2025
27 of 31 checks passed
vcunat pushed a commit that referenced this pull request Aug 7, 2025
The next haskellPackages bulk update will also resolve this, but picking
the patch will prevent a broken git-annex until the next staging-next is
merged into master.

(cherry picked from commit 75542a9)
(from PR #424682)
https://hydra.nixos.org/build/303801265
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 29, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-424682-to-release-25.05 origin/release-25.05
cd .worktree/backport-424682-to-release-25.05
git switch --create backport-424682-to-release-25.05
git cherry-pick -x 75542a9b8781b58538ec3755fdc3816c67c7a166

@vcunat
Copy link
Member

vcunat commented Aug 29, 2025

Ah, my bad. The thing experienced on current release-25.05 is a regression caused by this patch which we already have there. https://git-annex.branchable.com/bugs/flaky_test_failure_add_dup/

@vcunat
Copy link
Member

vcunat commented Aug 29, 2025

Fixed in PR #438309

@sternenseemann sternenseemann deleted the gi--annex-git-2.50 branch August 29, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants