Skip to content

libavif: fix cmake files #424658

Merged
K900 merged 2 commits intoNixOS:stagingfrom
SuperSandro2000:libavif-cmake-fix
Jul 13, 2025
Merged

libavif: fix cmake files #424658
K900 merged 2 commits intoNixOS:stagingfrom
SuperSandro2000:libavif-cmake-fix

Conversation

@SuperSandro2000
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from K900, NickCao and ttuegel July 12, 2025 19:02
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 12, 2025
@nix-owners nix-owners bot requested review from LunNova, ilya-fedin, mjm and mkg20001 July 12, 2025 19:07
@vcunat
Copy link
Member

vcunat commented Jul 13, 2025

This isn't meant to get merged to staging-next, right?

Rebuild: linux 23181, darwin 9270

@vcunat vcunat marked this pull request as draft July 13, 2025 07:34
@SuperSandro2000 SuperSandro2000 changed the base branch from staging-next to staging July 13, 2025 12:24
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review July 13, 2025 12:24
@SuperSandro2000
Copy link
Member Author

Then we merge it into staging

@nixpkgs-ci nixpkgs-ci bot closed this Jul 13, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Jul 13, 2025
@K900 K900 merged commit 8664a9a into NixOS:staging Jul 13, 2025
51 of 57 checks passed
@SuperSandro2000 SuperSandro2000 deleted the libavif-cmake-fix branch July 14, 2025 10:25
typedrat added a commit to typedrat/nix-config that referenced this pull request Jul 17, 2025
@NyCodeGHG NyCodeGHG mentioned this pull request Jul 17, 2025
13 tasks
@turtton turtton mentioned this pull request Jul 19, 2025
3 tasks
marcin-serwin added a commit to marcin-serwin/libavif that referenced this pull request Jul 19, 2025
GNUInstallDirs defines CMAKE_INSTALL_INCLUDEDIR as a location
to install headers. This is important for distributions that
want to install development files under a different prefix, see
NixOS/nixpkgs#424658.

Signed-off-by: Marcin Serwin <[email protected]>
marcin-serwin added a commit to marcin-serwin/libavif that referenced this pull request Jul 19, 2025
GNUInstallDirs defines CMAKE_INSTALL_INCLUDEDIR as a location
to install headers. This is important for distributions that
want to install development files under a different prefix, see
NixOS/nixpkgs#424658.

Signed-off-by: Marcin Serwin <[email protected]>
wantehchang pushed a commit to AOMediaCodec/libavif that referenced this pull request Jul 22, 2025
GNUInstallDirs defines CMAKE_INSTALL_INCLUDEDIR as a location
to install headers. This is important for distributions that
want to install development files under a different prefix, see
NixOS/nixpkgs#424658.

Signed-off-by: Marcin Serwin <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2025
The generated cnats-config.cmake file looks for include files under $out
but should look for them under $dev. Fix this in the same way as, for
example, in [1]. See [2] for other instances.

[1] #424658
[2] https://github.com/NixOS/nixpkgs/issues?q=is%3Aissue%20_import_prefix
nixpkgs-ci bot pushed a commit that referenced this pull request Dec 13, 2025
The generated cnats-config.cmake file looks for include files under $out
but should look for them under $dev. Fix this in the same way as, for
example, in [1]. See [2] for other instances.

[1] #424658
[2] https://github.com/NixOS/nixpkgs/issues?q=is%3Aissue%20_import_prefix

(cherry picked from commit 0eaeed1)
pseudocc pushed a commit to pseudocc/nixpkgs that referenced this pull request Jan 9, 2026
The generated cnats-config.cmake file looks for include files under $out
but should look for them under $dev. Fix this in the same way as, for
example, in [1]. See [2] for other instances.

[1] NixOS#424658
[2] https://github.com/NixOS/nixpkgs/issues?q=is%3Aissue%20_import_prefix

(cherry picked from commit 0eaeed1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants