libmypaint: fix build#424557
Merged
yuyuyureka merged 1 commit intoNixOS:staging-nextfrom Jul 12, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
alyssais
requested changes
Jul 12, 2025
`dev` output unchanged (verified by `diffoscope`). `out` output still contains all the translation files, with no obvious encoding issues i spotted. Slight deviations in the metadata, but should be fine. Fixing the build with modern gettext requires replacing the obsolete glib gettext. Fixing the build with modern autoconf requires making IT_PROG_INTLTOOL unconditional, hence the indent changes in the patch.
LordGrimmauld
force-pushed
the
libmypaint-gettext-build
branch
from
acfb9a7 to
295517f
Compare
Contributor
Author
|
Ended up doing the patch by |
alyssais
approved these changes
Jul 12, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devoutput unchanged (verified bydiffoscope).outoutput still contains all the translation files, with no obvious encoding issues i spotted. Slightdeviations in the metadata, but should be fine.
This change is cursed. Part of the issue is libmypaint being broken with modern autoreconf [1], so before patching in the gettext build fixes, autoreconf needed fixing.
[1] mypaint/libmypaint#178
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.