Skip to content

Comments

ghc-{8.2.2,8.4.3}: "useLLVM" when target is musl as well#42455

Merged
dtzWill merged 2 commits intoNixOS:masterfrom
dtzWill:fix/ghc-musl-usellvm
Jun 23, 2018
Merged

ghc-{8.2.2,8.4.3}: "useLLVM" when target is musl as well#42455
dtzWill merged 2 commits intoNixOS:masterfrom
dtzWill:fix/ghc-musl-usellvm

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 23, 2018 •
edited
Loading

Without this build fails complaining unable to find LLVM,
with this option cross-x86_64-musl builds ghc's that at least
can build a simple hello-world "hello.hs".

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from peti as a code owner June 23, 2018 18:25
@dtzWill
Copy link
Member Author

dtzWill commented Jun 23, 2018

Building packages (including "hello") seems to run into problems,
but this is a start!

Here's the error when trying to build "hello": https://gist.github.com/09a713cf27a317a9667831a95e4a1483

Oh! ghc843 doesn't have the fixes introduced with #37598 . Let's see how 822 does...

@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 23, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Jun 23, 2018

With this ghc822 works (again?) with cross-musl (targeting x86_64-unknown-linux-musl or aarch64-multiplatform-musl, at least for the simple "hello" package!

@dtzWill dtzWill requested a review from Ericson2314 June 23, 2018 19:49
@dtzWill
Copy link
Member Author

dtzWill commented Jun 23, 2018

Well this looks safe (borg says 0 rebuilds) so going ahead!

LMK if you have any thoughts/comments, thanks!

@dtzWill dtzWill merged commit 2e5e26d into NixOS:master Jun 23, 2018
@dtzWill dtzWill deleted the fix/ghc-musl-usellvm branch June 23, 2018 23:09
This was referenced Jun 25, 2018
Merged
Merged
@nh2 nh2 mentioned this pull request May 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peti peti Awaiting requested review from peti

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dtzWill @GrahamcOfBorg