Skip to content

lib3mf: 2.3.2 -> 2.4.1, fix build, add updateScript#424347

Merged
K900 merged 2 commits intoNixOS:staging-nextfrom
LordGrimmauld:lib3mf-fix
Jul 12, 2025
Merged

lib3mf: 2.3.2 -> 2.4.1, fix build, add updateScript#424347
K900 merged 2 commits intoNixOS:staging-nextfrom
LordGrimmauld:lib3mf-fix

Conversation

@LordGrimmauld
Copy link
Contributor

Hydra failure: https://hydra.nixos.org/build/301834239

release notes: https://github.com/3MFConsortium/lib3mf/releases/tag/v2.4.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld LordGrimmauld added the 0.kind: build failure A package fails to build label Jul 11, 2025
@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Jul 11, 2025

I'll see if openscad builds on top of this. If that works i call this good, but that test is pending.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 11, 2025
@LordGrimmauld
Copy link
Contributor Author

okay, openscad builds on top of this, good enough i guess

@LordGrimmauld
Copy link
Contributor Author

Seeing as lib3mf has no maintainers, i'll request the openscad maintainers to take a look

@K900 K900 merged commit 10b60fa into NixOS:staging-next Jul 12, 2025
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: build failure A package fails to build 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants