patch-shebangs: fix binary data corrupt after patching#423137
Merged
K900 merged 1 commit intoNixOS:stagingfrom Jul 7, 2025
Merged
patch-shebangs: fix binary data corrupt after patching#423137K900 merged 1 commit intoNixOS:stagingfrom
K900 merged 1 commit intoNixOS:stagingfrom
Conversation
This removes the recently introduced shell based implementation of `sponge` which wasn't capable of managing binary input. Now, a tmpFile under $TMPDIR is created manually and later deleted see: NixOS#414448 (comment)
13 tasks
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
K900
reviewed
Jul 7, 2025
Mic92
approved these changes
Jul 7, 2025
Member
Mic92
left a comment
Mic92
left a comment
There was a problem hiding this comment.
Passes my eye ball test. Haven't tried to build anything with it.
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
Author
|
I built cmake on x86_64 with this successfully |
Contributor
|
Built Akkoma with 41d70b1 reverted and this applied, it builds and runs. |
Member
Author
|
My infra built successfully with this. |
13 tasks
Contributor
|
Thanks for fixing this. |
13 tasks
3 tasks
This was referenced Jul 20, 2025
wi11-holdsworth
added a commit
to wi11-holdsworth/dots
that referenced
this pull request
Jul 22, 2025
3 tasks
3 tasks
terlar
added a commit
to terlar/nixpkgs
that referenced
this pull request
Jul 30, 2025
This was discovered with issues related to pnpm that hard links on some systems, see NixOS#426636. This is a regression introduced by NixOS#414448 and NixOS#423137. When `sed -i` is used on a file with hard links, then the file is seperated and only the file named in the command is changed.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the recently introduced shell based implementation of
spongewhich wasn't capable of managing binary input.Now, a tmpFile under $TMPDIR is created manually and later deleted
see: #414448 (comment)
To run the tests:
nix-build -A tests.hooks.default-stdenv-hooks.patch-shebangsThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.