Skip to content

nixosTests.kexec: fix test#423097

Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom
jmbaur:fix-kexec-test
Jul 7, 2025
Merged

nixosTests.kexec: fix test#423097
ConnorBaker merged 1 commit intoNixOS:masterfrom
jmbaur:fix-kexec-test

Conversation

@jmbaur
Copy link
Contributor

@jmbaur jmbaur commented Jul 7, 2025

The kexec test has been broken since
878922a, which breaks the read-only package-set enforcement that tests have.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

The kexec test has been broken since
878922a, which breaks the read-only
package-set enforcement that tests have.
@jmbaur jmbaur requested review from Lassulus and flokli July 7, 2025 04:13
@nixpkgs-ci nixpkgs-ci bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 7, 2025
@ConnorBaker ConnorBaker mentioned this pull request Jul 7, 2025
13 tasks
@ConnorBaker
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 423097 --package nixosTests.kexec
Commit: 7e04a534ad19b31448c98550bcd3d9c51eb1cd06


x86_64-linux

✅ 1 test built:
  • nixosTests.kexec

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 7, 2025
@ConnorBaker ConnorBaker merged commit 73feb5e into NixOS:master Jul 7, 2025
30 of 34 checks passed
@jmbaur jmbaur deleted the fix-kexec-test branch July 7, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants