postgresql.withPackages: add dev output#422969
Conversation
This avoids leaking the dev output and all its dependencies into regular postgresql.withPackages builds, most notably postgresql_jit.
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
| }; | ||
| }).overrideAttrs | ||
| { | ||
| # buildEnv doesn't support passing `outputs`, so going via overrideAttrs. |
There was a problem hiding this comment.
Not a big fan of this, but OK.
There was a problem hiding this comment.
Yeah, neither am I. Not sure whether support for this should be added to buildEnv, though. Seems like quite a special case.
There was a problem hiding this comment.
Hmm, I haven't tested yet, but are there ways this could mess up splicing?
Like, the fix is good enouh and I done pretty much the same, but I do wonder if it'd be OK to just accept outputs in buildEnv. Like, in the end it's another derivation (that can be modified with overrideAttrs -- as done right now), so I'd argue this is OK even though it's technically a larger API surface 🤔
Thoughts?
There was a problem hiding this comment.
I'd probably defer answering this question till after buildEnv has structuredAttrs support. That's because I wanted to add outputChecks as well to prevent regressions, but those only work with structuredAttrs. And enabling them.. broke the whole buildEnv. So I intend to, eventually, first fix structuredAttrs, then look output+checks support at once.
3 participants
This avoids leaking the dev output and all its dependencies into regular postgresql.withPackages builds, most notably postgresql_jit.
Fixes #419486 (comment), thanks for the report @K900.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageAdd a 👍 reaction to pull requests you find important.