Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
MisileLab
approved these changes
Jul 6, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
13 tasks
Member
What are you referring to here? Given this, does it even make sense to add ad hoc workarounds for the current problems on |
Member
Author
|
autoconf doesn't see a lot of upstream maintenance, so "upcoming" could be quite far in the future to even get those changes reviewed. The alternative is keeping gettext outdated, applying non-upstream autoconf patches we don't have anybody very qualified to review, or leaving all those packages broken indefinitely. The patches I'm referring to are at https://savannah.gnu.org/support/index.php?111272. Still no response from upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sadly isn't enough on its own to resolve any of the 0.25 regressions, but in combination with upcoming autoconf changes it will be.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.