Skip to content

unityhub: drop 2019 support to fix build, 3.12.1 -> 3.13.1#422785

Merged
SuperSandro2000 merged 5 commits intoNixOS:masterfrom
huantianad:unityhub-313
Aug 4, 2025
Merged

unityhub: drop 2019 support to fix build, 3.12.1 -> 3.13.1#422785
SuperSandro2000 merged 5 commits intoNixOS:masterfrom
huantianad:unityhub-313

Conversation

@huantianad
Copy link
Contributor

@huantianad huantianad commented Jul 5, 2025 •
edited
Loading

Closes #412803
Closes #418451
Closes #419634

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 5, 2025
SkyLeite
SkyLeite reviewed Jul 7, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 7, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 8, 2025
@huantianad
Copy link
Contributor Author

huantianad commented Jul 15, 2025

@SuperSandro2000 since you were just here, could you help merge?

@huantianad huantianad force-pushed the unityhub-313 branch 2 times, most recently from 0fedd9c to d516ef2 Compare July 25, 2025 06:18
@PassiveLemon
Copy link
Contributor

PassiveLemon commented Jul 30, 2025 •
edited
Loading

I just gave the unityhub package from the patched fork branch a test, however I am unable to normally start Unity. Running it from Unity Hub or Alcom and it fails with this error in info-log.json:

{"timestamp":"2025-07-30T18:36:08.273Z","level":"info","moduleName":"LaunchProcess","pid":843147,"message":"Spawning editor instance with command:  /home/lemon/Documents/Unity/Installs/2022.3.22f1/Editor/Unity , and arguments:  [ '-projectpath', '/home/lemon/Documents/Unity/Projects/<project>', '-useHub', '-hubIPC', '-cloudEnvironment', 'production', '-licensingIpc', 'LicenseClient-lemon', '-hubSessionId', '<redacted>', '-accessToken', '<redacted>' ]"}
{"timestamp":"2025-07-30T18:36:08.289Z","level":"info","moduleName":"LaunchProcess","pid":843147,"message":"child process exited with code 127"}
{"timestamp":"2025-07-30T18:36:08.289Z","level":"error","moduleName":"EditorApp","pid":843147,"message":"Editor exited with code 127"}
{"timestamp":"2025-07-30T18:36:08.295Z","level":"error","moduleName":"LocalProjectService","pid":843147,"message":"Error while opening a local new project Error: Editor exited with code 127\n    at ChildProcess.<anonymous> (/nix/store/9bi7q54k8wgahiis869qkzkgpbmnxg6j-unityhub-3.13.0/opt/unityhub/resources/app.asar/build/main/services/editorApp/editorapp.js:1:2807)\n    at ChildProcess.emit (node:events:530:35)\n    at ChildProcess.emit (node:domain:489:12)\n    at maybeClose (node:internal/child_process:1101:16)\n    at ChildProcess._handle.onexit (node:internal/child_process:304:5)\n    at Process.callbackTrampoline (node:internal/async_hooks:130:17)"}

Running the exact command it tried in the terminal informs me that it does not like the dynamically linked exe:

Could not start dynamically linked executable: /home/lemon/Documents/Unity/Installs/2022.3.22f1/Editor/Unity
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld

If I run the command with steam-run like so steam-run /home/lemon/Documents/Unity/Installs/2022.3.22f1/Editor/Unity -projectpath /home/lemon/Documents/Unity/Projects/<project> -useHub -hubIPC -cloudEnvironment production -licensingIpc LicenseClient-lemon -hubSessionId <redacted> -accessToken <redacted> then Unity will start up.

I used to run it fine (without needing steam-run) before the build was broken, so not sure what's up with it

@huantianad huantianad force-pushed the unityhub-313 branch 2 times, most recently from cea0cc1 to 0e85898 Compare August 2, 2025 21:55
@huantianad huantianad changed the title unityhub: drop 2019 support to fix build, 3.12.1 -> 3.13.0 unityhub: drop 2019 support to fix build, 3.12.1 -> 3.13.1 Aug 2, 2025
@huantianad huantianad mentioned this pull request Aug 2, 2025
Closed
13 tasks
@huantianad
Copy link
Contributor Author

huantianad commented Aug 3, 2025

@PassiveLemon that seems to be due to the libxml change, I've given up and just overrided the package to use the old version for now, before staging is merged into master.

@PassiveLemon
Copy link
Contributor

PassiveLemon commented Aug 3, 2025

Can confirm that it now works

SuperSandro2000
SuperSandro2000 reviewed Aug 3, 2025
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@huantianad
Copy link
Contributor Author

huantianad commented Aug 3, 2025

Thanks for the suggestions, fixed

@SuperSandro2000 SuperSandro2000 merged commit f9228db into NixOS:master Aug 4, 2025
25 of 27 checks passed
@huantianad huantianad deleted the unityhub-313 branch August 5, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

+1 more reviewer

@SkyLeite SkyLeite SkyLeite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't create any project in UnityHub Build failure: unityhub unityhub: FontAsset.cs and Liberation Sans Do Not Exist

4 participants

@huantianad @PassiveLemon @SuperSandro2000 @SkyLeite