rsync: fix checkPhase on sandboxed Darwin#422649
Closed
al3xtjames wants to merge 2 commits intoNixOS:stagingfrom
Closed
rsync: fix checkPhase on sandboxed Darwin#422649al3xtjames wants to merge 2 commits intoNixOS:stagingfrom
checkPhase on sandboxed Darwin#422649al3xtjames wants to merge 2 commits intoNixOS:stagingfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
ofalvai
approved these changes
Jul 9, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
The test scripts try to access directories which are inaccessible outside of the sandbox (/etc and /) which causes the tests to fail [1]. Add a patch to make the test scripts use an accessible directory (the source root) instead. [1]: https://gist.github.com/al3xtjames/698ce795e308a18ca1fa85bd883ed661
8e8f7c7 ("rsync: unblock tests on darwin") removed fakeroot from rsync's checkInputs on Darwin. fakeroot has since been fixed on Darwin in d4a746a608b4 ("fakeroot: add patches for Darwin"). Re-add fakeroot to enable the currently-skipped chown and device tests.
al3xtjames
force-pushed
the
rsync-darwin
branch
from
7103a5b to
011e29d
Compare
13 tasks
Contributor
Author
|
Addressed by #431202. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test scripts try to access directories which are inaccessible outside of the sandbox (/etc and /) which causes the tests to fail. Add a patch to make the test scripts use an accessible directory (the source root) instead.
Also add fakeroot to checkInputs enable the currently-skipped chown and device tests (as it now works on Darwin).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.