kexec-tools: fix static build#422618
Merged
ConnorBaker merged 1 commit intoNixOS:stagingfrom Jul 7, 2025
Merged
Conversation
lzcunt
reviewed
Jul 5, 2025
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
As per the comment in kexec-tools source, `ZSTD_isFrame` is a ```c /* * Reimplementation of private function available if zstd is * statically linked. Remove when it becomes public. */ ``` This patch pulls in a fix that allows for these duplicate symbols to link successfully.
jmbaur
force-pushed
the
kexec-tools-static
branch
from
196194f to
bc884bc
Compare
lzcunt
approved these changes
Jul 6, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
|
ConnorBaker
approved these changes
Jul 7, 2025
nixpkgs-ci
bot
added
12.approvals: 2
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the comment in kexec-tools source,
ZSTD_isFrameis aThis patch pulls in a fix that allows for these duplicate symbols to link successfully.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.