Skip to content

postgresqlPackages: fix update scripts with PG versioning scheme#422133

Merged
wolfgangwalther merged 7 commits intoNixOS:masterfrom
wolfgangwalther:postgresql-pkgs-pg-squeeze
Aug 8, 2025
Merged

postgresqlPackages: fix update scripts with PG versioning scheme#422133
wolfgangwalther merged 7 commits intoNixOS:masterfrom
wolfgangwalther:postgresql-pkgs-pg-squeeze

Conversation

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Jul 3, 2025

PostgreSQL itself and some of its extensions use a REL_X_Y_Z versioning scheme, or similar - delimiting by _ instead of ..

This fixes the update scripts for those packages. Depends on:

Things done


Add a 👍 reaction to pull requests you find important.

@wolfgangwalther wolfgangwalther force-pushed the postgresql-pkgs-pg-squeeze branch from 8a88129 to 5105fd4 Compare July 3, 2025 16:23
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jul 3, 2025
@wolfgangwalther
Copy link
Contributor Author

@philiptaron you didn't like this in #359659 (comment), I guess you like it here better.

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like it better.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2025
@wolfgangwalther wolfgangwalther force-pushed the postgresql-pkgs-pg-squeeze branch from 05d9312 to adaab0a Compare August 8, 2025 07:52
@wolfgangwalther wolfgangwalther marked this pull request as ready for review August 8, 2025 07:53
@nix-owners nix-owners bot requested review from Ma27, euank, qoelet and thoughtpolice August 8, 2025 07:54
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 8, 2025
@wolfgangwalther
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422133
Commit: adaab0a3f9a3e2fe71e8b47c44128b9b43786459


x86_64-linux

✅ 18 packages built:
  • postgresql13Packages.pg_squeeze
  • postgresql13Packages.plr
  • postgresql13Packages.wal2json
  • postgresql14Packages.pg_squeeze
  • postgresql14Packages.plr
  • postgresql14Packages.wal2json
  • postgresql15Packages.pg_squeeze
  • postgresql15Packages.plr
  • postgresql15Packages.wal2json
  • postgresql16Packages.pg_squeeze
  • postgresql16Packages.plr
  • postgresql16Packages.wal2json
  • postgresqlPackages.pg_squeeze (postgresql17Packages.pg_squeeze)
  • postgresqlPackages.plr (postgresql17Packages.plr)
  • postgresqlPackages.wal2json (postgresql17Packages.wal2json)
  • postgresql18Packages.pg_squeeze
  • postgresql18Packages.plr
  • postgresql18Packages.wal2json

aarch64-linux

✅ 18 packages built:
  • postgresql13Packages.pg_squeeze
  • postgresql13Packages.plr
  • postgresql13Packages.wal2json
  • postgresql14Packages.pg_squeeze
  • postgresql14Packages.plr
  • postgresql14Packages.wal2json
  • postgresql15Packages.pg_squeeze
  • postgresql15Packages.plr
  • postgresql15Packages.wal2json
  • postgresql16Packages.pg_squeeze
  • postgresql16Packages.plr
  • postgresql16Packages.wal2json
  • postgresqlPackages.pg_squeeze (postgresql17Packages.pg_squeeze)
  • postgresqlPackages.plr (postgresql17Packages.plr)
  • postgresqlPackages.wal2json (postgresql17Packages.wal2json)
  • postgresql18Packages.pg_squeeze
  • postgresql18Packages.plr
  • postgresql18Packages.wal2json

x86_64-darwin

✅ 18 packages built:
  • postgresql13Packages.pg_squeeze
  • postgresql13Packages.plr
  • postgresql13Packages.wal2json
  • postgresql14Packages.pg_squeeze
  • postgresql14Packages.plr
  • postgresql14Packages.wal2json
  • postgresql15Packages.pg_squeeze
  • postgresql15Packages.plr
  • postgresql15Packages.wal2json
  • postgresql16Packages.pg_squeeze
  • postgresql16Packages.plr
  • postgresql16Packages.wal2json
  • postgresqlPackages.pg_squeeze (postgresql17Packages.pg_squeeze)
  • postgresqlPackages.plr (postgresql17Packages.plr)
  • postgresqlPackages.wal2json (postgresql17Packages.wal2json)
  • postgresql18Packages.pg_squeeze
  • postgresql18Packages.plr
  • postgresql18Packages.wal2json

aarch64-darwin

✅ 18 packages built:
  • postgresql13Packages.pg_squeeze
  • postgresql13Packages.plr
  • postgresql13Packages.wal2json
  • postgresql14Packages.pg_squeeze
  • postgresql14Packages.plr
  • postgresql14Packages.wal2json
  • postgresql15Packages.pg_squeeze
  • postgresql15Packages.plr
  • postgresql15Packages.wal2json
  • postgresql16Packages.pg_squeeze
  • postgresql16Packages.plr
  • postgresql16Packages.wal2json
  • postgresqlPackages.pg_squeeze (postgresql17Packages.pg_squeeze)
  • postgresqlPackages.plr (postgresql17Packages.plr)
  • postgresqlPackages.wal2json (postgresql17Packages.wal2json)
  • postgresql18Packages.pg_squeeze
  • postgresql18Packages.plr
  • postgresql18Packages.wal2json

lib.strings.removePrefix "wal2json_" finalAttrs.src.rev
)}";
version = "2.6";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, because I was confused myself: This causes a rebuild for wal2json, because finalAttrs.src.rev was not correct anymore after the change to src.tag. Thus the version was not set correctly, but now it is, again.

@wolfgangwalther wolfgangwalther merged commit 253c2c1 into NixOS:master Aug 8, 2025
26 of 31 checks passed
@wolfgangwalther wolfgangwalther deleted the postgresql-pkgs-pg-squeeze branch August 8, 2025 10:19
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 8, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants