[Backport release-25.05] check-meta: fix 'hasNoMaintainers'#422019
Merged
wolfgangwalther merged 1 commit intorelease-25.05from Jul 3, 2025
Merged
[Backport release-25.05] check-meta: fix 'hasNoMaintainers'#422019wolfgangwalther merged 1 commit intorelease-25.05from
wolfgangwalther merged 1 commit intorelease-25.05from
Conversation
broken in 650eb61 Previously, if any of `meta.teams` or `meta.maintainers` was undefined, `hasNoMaintainers` would return false, suggesting e.g. bash had a maintainer - it does not. The old logic before meta.teams was: ```nix hasNoMaintainers = attrs: attrs ? meta.maintainers && (length attrs.meta.maintainers) == 0; ``` This meant a package that did not define `meta.maintainers` would appear maintained by this check, while a package with `meta.maintainers = []` would be listed as unmaintained. This might have been a bug. If it was not, that logic could be restored by prepending an extra check to the condition: ```nix (attrs ? meta.maintainers || attrs ? meta.teams) && (attrs.meta.maintainers or [] == []) && (attrs.meta.teams or [] == []) ``` I believe this makes little sense though. if no maintainer is listed, a package should be considered unmaintained. If really desired, this can still be bypassed by setting `meta.maintainers = null;` or something. (cherry picked from commit 1ae214f)
13 tasks
WilliButz
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-25.05, triggered by a label in #412184.