maintainers: add msgilligan#421885
Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom Jul 3, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Contributor
|
We generally want to add the maintainers-list entry in the same PR where you're added to that package as a maintainer. That's because otherwise we risk merging this, never coming around to do the other PR - and then having an unused maintainer entry. Maybe @emmanuelrosa can cherry-pick this into their PR if it already exists? If it does not exist, yet - @msgilligan you can just add yourself as a maintainer to sparrow in a second commit in here. |
Contributor
Author
Done. |
wolfgangwalther
approved these changes
Jul 2, 2025
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
Diff LGTM, waiting for existing sparrow maintainers to give feedback on the addition.
nixpkgs-ci
bot
added
the
12.approvals: 1
nixpkgs-ci
bot
added
12.approvals: 2
Contributor
|
Welcome to Nixpkgs! |
Contributor
Author
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@emmanuelrosa will be adding me as a maintainer of
sparrow, so please add me to the maintainers list.