Skip to content

Comments

pythonPackages.sqlalchemy: 1.2.7 -> 1.2.8#42180

Closed
dtzWill wants to merge 1 commit intoNixOS:stagingfrom
dtzWill:update/sqlalchemy-1.2.8
Closed

pythonPackages.sqlalchemy: 1.2.7 -> 1.2.8#42180
dtzWill wants to merge 1 commit intoNixOS:stagingfrom
dtzWill:update/sqlalchemy-1.2.8

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 18, 2018

http://docs.sqlalchemy.org/en/latest/changelog/changelog_12.html#change-1.2.8

Also fixes test failures w/musl, although I haven't investigated this
further than seeing if they persisted with most recent version O:).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner June 18, 2018 21:19
@GrahamcOfBorg GrahamcOfBorg added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jun 18, 2018
@dtzWill dtzWill mentioned this pull request Jun 18, 2018
Merged
8 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Jun 18, 2018

Oh I didn't expect so many things to depend on this. Will send to staging instead.

@dtzWill dtzWill force-pushed the update/sqlalchemy-1.2.8 branch from 2e4e855 to 2c7b0cb Compare June 18, 2018 22:56
@dtzWill dtzWill requested review from Ericson2314, nbp and peti as code owners June 18, 2018 22:56
@dtzWill dtzWill changed the base branch from master to staging June 18, 2018 22:56
@dtzWill dtzWill removed request for Ericson2314, nbp and peti June 18, 2018 22:56
@dtzWill
Copy link
Member Author

dtzWill commented Jun 18, 2018

(sorry for auto-review-requests issued while rebasing + telling github about it)

@GrahamcOfBorg GrahamcOfBorg added 6.topic: emacs Text editor 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: stdenv Standard environment labels Jun 18, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Jun 18, 2018

Waiting at least a bit for @FRidh's approval :).

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: package (new) This PR adds a new package labels Jun 18, 2018
@nh2
Copy link
Contributor

nh2 commented Jun 22, 2018 •
edited
Loading

@dtzWill What does the error look like that this fixes? Could you post them?

I found some other python tests in some other builds (dependencies of ghc) failing with musl that are related to TCP buffers (namely pyca/pyopenssl#768), and woud like to know if this is somewhat similar.

@FRidh FRidh self-assigned this Jun 22, 2018
@FRidh
Copy link
Member

FRidh commented Jun 22, 2018

I've just pushed this update to staging.

@FRidh FRidh closed this Jun 22, 2018
@nh2 nh2 mentioned this pull request Sep 11, 2018
Closed
@nh2 nh2 mentioned this pull request Nov 13, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels

6.topic: emacs Text editor 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dtzWill @nh2 @FRidh @GrahamcOfBorg