patchShebangs: fix crash on read-only files#421389
Merged
K900 merged 2 commits intoNixOS:stagingfrom Jul 1, 2025
Merged
Conversation
- Add test to ensure ability to patch read-only-files (see NixOS#414448 (comment)) - Add test to ensure the timestamp is preserved - Add test to ensure read-only permissions are preserved
Fixes a regression introduced by c1cc6ff where patchShebangs would crash if a file is read-only
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #414448 which makes patchShebangs crash if a file is read-only.
See comment on that PR for details: #414448 (comment)
This also adds a bunch of tests which would have cought that.
To test this change, execute:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.