Skip to content

fix regenerate-hackage-packages#421127

Merged
maralorn merged 2 commits intoNixOS:haskell-updatesfrom
peterbecich:fix-regenerate-hackage
Jun 30, 2025
Merged

fix regenerate-hackage-packages#421127
maralorn merged 2 commits intoNixOS:haskell-updatesfrom
peterbecich:fix-regenerate-hackage

Conversation

@peterbecich
Copy link
Contributor

@peterbecich peterbecich commented Jun 29, 2025 

./maintainers/scripts/haskell/update-cabal2nix-unstable.sh
./maintainers/scripts/haskell/regenerate-hackage-packages.sh

It works now.

Error was:

...
hackage2nix: user error (cannot parse cabal file /nix/store/kmz1d73l5k1nhv5269dl5i68yjwlbcir-unpacked-cabal-hashes/pms-application-service/0.0.3.0/pms-application-service.cabal)
hackage2nix: thread blocked indefinitely in an MVar operation

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Jun 29, 2025
@maralorn
Copy link
Member

maralorn commented Jun 29, 2025

Currently your commit messages does not match our contributing guidelines.

Besides that I am slightly confused because we already had a cabal2nix-unstable bump quite recently. Wondering where that is and whether that will create a merge conflict or something at some point.

@peterbecich peterbecich force-pushed the fix-regenerate-hackage branch from e054baf to 217d063 Compare June 29, 2025 23:25
@peterbecich
haskellPackages.cabal2nix: unstable-2025-04-30 -> unstable-2025-06-14
4d5170a 
This update fixes the `regenerate-hackage-packages` script.

```
./maintainers/scripts/haskell/update-cabal2nix-unstable.sh
```

Previously, `regenerate-hackage-packages` failed with:
```
...
hackage2nix: user error (cannot parse cabal file /nix/store/kmz1d73l5k1nhv5269dl5i68yjwlbcir-unpacked-cabal-hashes/pms-application-service/0.0.3.0/pms-application-service.cabal)
hackage2nix: thread blocked indefinitely in an MVar operation
```
@peterbecich peterbecich force-pushed the fix-regenerate-hackage branch from 217d063 to 4d5170a Compare June 29, 2025 23:29
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 29, 2025
@peterbecich
haskellPackages: regenerate package set based on current config
5e6d29f 
```
./maintainers/scripts/haskell/regenerate-hackage-packages.sh
```

No update of Hackage or Stackage.
@nixpkgs-ci nixpkgs-ci bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 29, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jun 30, 2025

Besides that I am slightly confused because we already had a cabal2nix-unstable bump quite recently. Wondering where that is and whether that will create a merge conflict or something at some point.

That was in #416056, which apparently targeted staging. So the answer is yes. Should we cherry-pick that PR into haskell-updates instead or so?

@maralorn
Copy link
Member

maralorn commented Jun 30, 2025 •
edited
Loading

Well, since the commits seem to be completely identical the merge should just go through. I don’t think converting this into a cherry-pick will gain us anything.

@maralorn maralorn merged commit 7ebf8c0 into NixOS:haskell-updates Jun 30, 2025
25 of 27 checks passed
@sternenseemann
Copy link
Member

sternenseemann commented Jun 30, 2025

@peterbecich The issue you were seeing must have been due to another issue. Nothing in the commit range of the update of cabal2nix-unstable fixes such a failure. In fact, cabal2nix doesn't implement parsing cabal files, so all other things being equal, updating it would never make a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterbecich @maralorn @wolfgangwalther @sternenseemann