Merged
Conversation
configure.ac uses the AM_ICONV macro, which is part of gettext. The patch makes autoreconf recognise the project as using gettext, which has the added benefit of meaning we no longer need to run makeconf.sh, and can rely on just the autoreconf from autoreconfHook. Previously, we were actually doing autoreconf twice; once from the hook and once from the script, which I doubt was intentional…
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
trofi
approved these changes
Jun 30, 2025
Contributor
trofi
left a comment
trofi
left a comment
There was a problem hiding this comment.
Fixes fuse2 build for me on x86_64-linux in staging branch. Thank you!
nixpkgs-ci
bot
added
the
12.approvals: 1
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure.ac uses the AM_ICONV macro, which is part of gettext. The patch makes autoreconf recognise the project as using gettext, which has the added benefit of meaning we no longer need to run makeconf.sh, and can rely on just the autoreconf from autoreconfHook.
Previously, we were actually doing autoreconf twice; once from the hook and once from the script, which I doubt was intentional…
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.