Skip to content

haskellPackages.env-extra: fix flaky test failures#420873

Merged
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:env-extra-no-flaky-tests
Jun 30, 2025
Merged

haskellPackages.env-extra: fix flaky test failures#420873
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:env-extra-no-flaky-tests

Conversation

@sternenseemann
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from maralorn and wolfgangwalther June 28, 2025 22:42
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Jun 28, 2025
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 420873
Commit: de3611a70226356e87fbfa52e5657712b0bf35a3


x86_64-linux

✅ 2 packages built:
  • haskellPackages.env-extra
  • haskellPackages.env-extra.doc

aarch64-linux

✅ 2 packages built:
  • haskellPackages.env-extra
  • haskellPackages.env-extra.doc

x86_64-darwin

✅ 2 packages built:
  • haskellPackages.env-extra
  • haskellPackages.env-extra.doc

aarch64-darwin

✅ 2 packages built:
  • haskellPackages.env-extra
  • haskellPackages.env-extra.doc

Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a run of treefmt, otherwise LGTM.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 29, 2025
@sternenseemann sternenseemann force-pushed the env-extra-no-flaky-tests branch from de3611a to 1df9407 Compare June 30, 2025 11:36
@sternenseemann
Copy link
Member Author

Done.

@wolfgangwalther wolfgangwalther merged commit 7f1db76 into NixOS:haskell-updates Jun 30, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants